Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Announcement: New version with support for image/css urls with query arguments and anchor tags #97

Open
amorey opened this issue Sep 25, 2019 · 0 comments

Comments

@amorey
Copy link
Member

amorey commented Sep 25, 2019

Hi Everyone,

I just wanted to let you know that we released a new version of LoadJS (v4.0.0) that includes support for automatic detection of image/css urls with query arguments and anchor tags. Previously you had to force treat such urls using "img!" and "css!" tags:

loadjs(
  [
    'img!image.jpg?arg=val',
    'img!image.jpg#anchortag',
    'css!style.css?arg=val',
    'css!style.css#anchortag'
  ],
  function () {}
);

Now urls of this type are detected automatically:

loadjs(
  [
    'image.jpg?arg=val',
    'image.jpg#anchortag',
    'style.css?arg=val',
    'style.css#anchortag'
  ],
  function () {}
);

Although this seems like a small change, it could cause backwards compatibility issues for users using anchor tag workarounds to force treat urls as image/css files (e.g. "handler?arg=val#.css"). As a result we are treating this as a major version release.

Please try out the new feature and let me know if notice any issues.

Andres

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant