Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Etcd client support: stop traffic to in-defragmentation-server #124763

Open
Yiqing-Liu opened this issue May 8, 2024 · 2 comments
Open

Add Etcd client support: stop traffic to in-defragmentation-server #124763

Yiqing-Liu opened this issue May 8, 2024 · 2 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery.

Comments

@Yiqing-Liu
Copy link

What would you like to be added?

Etcd defragmentation is the workflow to prevent etcd from running out of disk space.
It is expected that defragmentation will result in timeouts and latency to requests that happen to be connected to the node being defragmented.

There is a proposal to stop traffic sending to being-defragmented-etcd-node.
etcd-io/etcd#16278

The Etcd server's implementation has been merged in etcd-io/etcd#17914, which is guarded by a feature flag.

Propose client side make the corresponding change (which can be guarded by feature flag as well) to complete the implementation.

Why is this needed?

This work will largely mitigate the Etcd defrag impact, decreasing the 5xx error rate.
to address the reported issue: #93280

@Yiqing-Liu Yiqing-Liu added the kind/feature Categorizes issue or PR as related to a new feature. label May 8, 2024
@k8s-ci-robot k8s-ci-robot added needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels May 8, 2024
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Yiqing-Liu Yiqing-Liu changed the title Add Etcd client support: stop traffic to in-defragmentation-server Add Etcd client support: stop traffic to in-defragmentation-etcd-node May 8, 2024
@Yiqing-Liu Yiqing-Liu changed the title Add Etcd client support: stop traffic to in-defragmentation-etcd-node Add Etcd client support: stop traffic to in-defragmentation-server May 8, 2024
@pranav-pandey0804
Copy link

/sig api-machinery

@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery.
Projects
None yet
Development

No branches or pull requests

3 participants