Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FG:InPlacePodVerticalScaling] Implement version skew handling for in-place pod resize #117767

Open
vinaykul opened this issue May 3, 2023 · 31 comments
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. sig/node Categorizes an issue or PR as relevant to SIG Node.

Comments

@vinaykul
Copy link
Contributor

vinaykul commented May 3, 2023

What would you like to be added?

This is a tracking bug to implement two changes to better handle version skew as documented in https://github.com/kubernetes/enhancements/tree/master/keps/sig-node/1287-in-place-update-pod-resources#version-skew-strategy

  1. kubelet: When feature-gate is disabled, if kubelet sees a Proposed resize, it rejects the resize as Infeasible.
  2. scheduler: If PodStatus.Resize field is not empty, scheduler uses max(ResourcesAllocated, Requests) even if the feature-gate is disabled.

Why is this needed?

This is needed to gracefully handle component version skews that can occur during upgrades.

@vinaykul vinaykul added the kind/feature Categorizes issue or PR as related to a new feature. label May 3, 2023
@k8s-ci-robot k8s-ci-robot added needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels May 3, 2023
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vinaykul
Copy link
Contributor Author

vinaykul commented May 3, 2023

/sig node
/good-first-issue

@k8s-ci-robot
Copy link
Contributor

@vinaykul:
This request has been marked as suitable for new contributors.

Guidelines

Please ensure that the issue body includes answers to the following questions:

  • Why are we solving this issue?
  • To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
  • Does this issue have zero to low barrier of entry?
  • How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/sig node
/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. sig/node Categorizes an issue or PR as relevant to SIG Node. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 3, 2023
@infdahai
Copy link

infdahai commented May 4, 2023

/assign

@Sajiyah-Salat
Copy link

Hello @infdahai infdahai, are you working on this?

@Sajiyah-Salat
Copy link

According to description of pr. The changes are documented but implementation is still remaining, right?

@infdahai infdahai removed their assignment May 10, 2023
@infdahai
Copy link

@Sajiyah-Salat yeah, I just quit this.

@phs-sakshi
Copy link

phs-sakshi commented May 10, 2023

can I work on this issue?

@infdahai
Copy link

can I work on this issue?

you can just use /assign command

@carlory
Copy link
Member

carlory commented May 11, 2023

/assign

@lauchokyip
Copy link
Member

lauchokyip commented May 11, 2023

@carlory , seem like you have experienced in contributing upstream, do you want to give the chance to others for good-first-issue?

@carlory
Copy link
Member

carlory commented May 12, 2023

/unassign

@phs-sakshi
Copy link

/assign

@itiwarishubham
Copy link

/assign

@devilcrises
Copy link

/assign

@samyakjain10
Copy link

Hey everyone. Just saw this issue assigned to multiple people. Was curious to know if someone is working on it or is it up for grabs?

@phs-sakshi
Copy link

/unassign

@Bhanuteja01
Copy link

/assign

@Bhanuteja01
Copy link

Bhanuteja01 commented May 29, 2023

@vinaykul can you explain how to tackle with this issue?

@shubmjagtap
Copy link

/assign

@archits581
Copy link

/assign

@MeenuyD
Copy link

MeenuyD commented Jun 12, 2023

/assign

@shubmjagtap shubmjagtap removed their assignment Jun 13, 2023
@wlp1153468871
Copy link
Member

/assign

@EtherSol
Copy link

/assign

@pbialon
Copy link

pbialon commented Jun 20, 2023

/assign

@pbialon
Copy link

pbialon commented Jun 20, 2023

I don't understand the description (sorry for that, I'm a new contributor) (@vinaykul for visibility)

kubelet: When feature-gate is disabled, if kubelet sees a Proposed resize, it rejects the resize as Infeasible.

Is it a desired state description or a current state? If a current state, then what should be a desired behavior here?

@pbialon
Copy link

pbialon commented Jun 20, 2023

I've fixed (I guess) the first part in kubelet - @vinaykul please take a look when you're free.
If it is not what was expected here, please guide me 🙇

@pbialon
Copy link

pbialon commented Jun 23, 2023

@vinaykul hi, could you take a look? Or point out somebody who can take it over from you if you're not available?

@Shrihariii
Copy link

/assign

@pbialon
Copy link

pbialon commented Sep 3, 2023

@Shrihariii dunno if it makes sense for you to work on it - there is already an open pull request and discussion in it is going on.

@amomsi
Copy link

amomsi commented Feb 14, 2024

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. sig/node Categorizes an issue or PR as relevant to SIG Node.
Projects
Development

Successfully merging a pull request may close this issue.