Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve nfd-gc on NodeResourceTopology objects #1586

Open
marquiz opened this issue Feb 14, 2024 · 1 comment · May be fixed by #1700
Open

Improve nfd-gc on NodeResourceTopology objects #1586

marquiz opened this issue Feb 14, 2024 · 1 comment · May be fixed by #1700
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@marquiz
Copy link
Contributor

marquiz commented Feb 14, 2024

What would you like to be added:

We could possibly improve the behavior of nfd-gc by removing stale NRT objects (whose creator pod does not exist anymore). The ownerReference field shouldn't be used as that creates warnings (see k8s garbage-collection). We could use an nfd-specific annotation (like nfd.node.kubernetes.io/owner-pod: <namespace>/<pod-uuid>). The nfd-gc would delete the object if the pod doesn't exist. Possibly acting only if <namespace> is the same where nfd-gc itself is running (so that it doesn't need cluster-wide access to get/list all pods in all namespaces).

This would be a separate improvement in addiotion to #1551 (which didn't play out quite as I initially thought).

Why is this needed:

Better management of NRT objects. Potentially fewer stale objects in the cluster.

@marquiz marquiz added the kind/feature Categorizes issue or PR as related to a new feature. label Feb 14, 2024
@ozhuraki ozhuraki linked a pull request May 6, 2024 that will close this issue
@ozhuraki
Copy link
Contributor

ozhuraki commented May 6, 2024

/assign @ozhuraki

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants