Deleted Pending Pods count as active in Pod Groups

[alculquicondor]

What happened:

A Pending Pod (a Pod that doesn't have a scheduling gate, but it never got scheduled) is still considered as an "active" pod that cannot yet be replaced.

kueue/pkg/controller/jobs/pod/pod_controller.go

Line 731 in eaa43d3

return utilslices.Pick(p.list.Items, isPodRunnableOrSucceeded)

What you expected to happen:

A replacement Pod for a Pod that never got scheduled should be allowed to run

How to reproduce it (as minimally and precisely as possible):

1. Create a Pod, part of a pod group, with an unsatisfiable node-selector
2. Wait for the group to be admitted.
3. Delete the Pod manually
4. Create a replacement Pod (this Pod should not be deleted)

Anything else we need to know?:

Environment:

• Kubernetes version (use kubectl version):
• Kueue version (use git describe --tags --dirty --always):
• Cloud provider or hardware configuration:
• OS (e.g: cat /etc/os-release):
• Kernel (e.g. uname -a):
• Install tools:
• Others:

[alculquicondor]

/assign @trasc