Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add condition WaitingForReplacementPods for pod groups integration #2207

Closed
3 tasks
alculquicondor opened this issue May 15, 2024 · 2 comments · Fixed by #2234
Closed
3 tasks

Add condition WaitingForReplacementPods for pod groups integration #2207

alculquicondor opened this issue May 15, 2024 · 2 comments · Fixed by #2234
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@alculquicondor
Copy link
Contributor

What would you like to be added:

A condition WaitingForReplacementPods that is True when Kueue doesn't observe all the Pods declared for the group.

If Kueue was the one to delete Pods (due to preemption, waitForPodsReady, etc), then this should be included in the reason.
This can be achieved if Kueue adds the condition right before deleting Pods.

This condition can be independent of whether the Workload is admitted or not.

Why is this needed:

For visibility and for pod controllers to easily detect whether they need to replace pods.

Completion requirements:

This enhancement requires the following artifacts:

  • Design doc
  • API change
  • Docs update

The artifacts should be linked in subsequent comments.

@alculquicondor alculquicondor added the kind/feature Categorizes issue or PR as related to a new feature. label May 15, 2024
@alculquicondor
Copy link
Contributor Author

/assign @trasc

@mbobrovskyi
Copy link
Contributor

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants