Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add create clusterqueue command #2201

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Add create clusterqueue command #2201

wants to merge 12 commits into from
+1,171 −4

Conversation

IrvingMg
Copy link
Contributor

What type of PR is this?

/kind feature

What this PR does / why we need it:

Adds kueuectl create clusterqueue command.

Which issue(s) this PR fixes:

Fixes #2113

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Adds create clusterqueue command.

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. labels May 15, 2024
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels May 15, 2024
@netlify Netlify
Copy link

netlify bot commented May 15, 2024 •
edited

✅ Deploy Preview for kubernetes-sigs-kueue canceled.

Name Link
🔨 Latest commit 2ee9638
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/665876b29dc7060008469614

@IrvingMg
Copy link
Contributor Author

/test all

@IrvingMg IrvingMg force-pushed the feature/kueuectl-create-clusterqueue branch from 5cf6b77 to befd007 Compare May 15, 2024 07:05
@IrvingMg
Copy link
Contributor Author

/test all

@trasc
Copy link
Contributor

trasc commented May 15, 2024

/assign

@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels May 15, 2024
@IrvingMg
Copy link
Contributor Author

/test all

@IrvingMg
Copy link
Contributor Author

/test pull-kueue-test-integration-main

trasc
trasc reviewed May 17, 2024
View reviewed changes
Copy link
Contributor

@trasc trasc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit, otherwise LGTM

cmd/kueuectl/app/create/create_clusterqueue.go Outdated Show resolved Hide resolved
@IrvingMg IrvingMg marked this pull request as ready for review May 17, 2024 10:31
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 17, 2024
trasc
trasc reviewed May 20, 2024
View reviewed changes
Copy link
Contributor

@trasc trasc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 20, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 368c010db5d0aa55f1e3c79f3d73cb3539aec6c9

@mbobrovskyi
Copy link
Contributor

/assign @alculquicondor

vladikkuzn
vladikkuzn reviewed May 24, 2024
View reviewed changes
cmd/kueuectl/app/create/create_clusterqueue.go
Comment on lines +94 to +100
UserSpecifiedQueueingStrategy string
UserSpecifiedNamespaceSelector map[string]string
UserSpecifiedReclaimWithinCohort string
UserSpecifiedPreemptionWithinClusterQueue string
UserSpecifiedNominalQuota []string
UserSpecifiedBorrowingLimit []string
UserSpecifiedLendingLimit []string
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it worth extracting those to Flags, and then convert them to options there?
eg. The responsibility of flags would be to convert itself to options UserSpecifiedQueueingStrategy string -> QueueingStrategy v1beta1.QueueingStrategy
https://github.com/kubernetes/kubectl/blob/0bd9881b18755bc39933f5dea6bf3a219facf2f1/pkg/cmd/wait/wait.go#L135-L139
It's NIT, feel free to skip it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's similar to what we´re doing in the Complete function.

https://github.com/kubernetes-sigs/kueue/pull/2201/files/1e11470e48f47349b8a308062cdcdbb388f31c36#diff-0368570e85d858633cdc962dd769550580b5cb99d302acfccf23fed5d3d0ee6fR171

In there, the user inputs are being converted/parsed to valid values.

@alculquicondor
Copy link
Contributor

/assign @mwielgus

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 30, 2024
@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: IrvingMg
Once this PR has been reviewed and has the lgtm label, please ask for approval from alculquicondor. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbobrovskyi mbobrovskyi mbobrovskyi left review comments

@vladikkuzn vladikkuzn vladikkuzn left review comments

@denkensk denkensk Awaiting requested review from denkensk

@kerthcet kerthcet Awaiting requested review from kerthcet

@alculquicondor alculquicondor Awaiting requested review from alculquicondor

@mwielgus mwielgus Awaiting requested review from mwielgus

@trasc trasc Awaiting requested review from trasc

Assignees

@alculquicondor alculquicondor

@mwielgus mwielgus

@trasc trasc

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[kueuectl] Allow create ClusterQueue
7 participants
@IrvingMg @k8s-ci-robot @trasc @mbobrovskyi @alculquicondor @mwielgus @vladikkuzn