generated from kubernetes/kubernetes-template-project
-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing some validations for ConfigAPI #2084
Labels
kind/bug
Categorizes issue or PR as related to a bug.
Comments
/assign |
This was referenced May 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What happened:
The kubebuiler or controller-gen markers wouldn't work well since the ConfigAPI is not CRD.
So, we need to implement validations by ourselves, but we don't have some validations at the following APIs:
kueue/apis/config/v1beta1/configuration_types.go
Lines 205 to 225 in 5401a3b
kueue/apis/config/v1beta1/configuration_types.go
Lines 271 to 284 in 5401a3b
kueue/apis/config/v1beta1/configuration_types.go
Lines 347 to 354 in f108fef
kueue/apis/config/v1beta1/configuration_types.go
Lines 184 to 196 in cfd576f
What you expected to happen:
Once the KueueConfig with invalid parameters is created, the kueue-controller-manager raises the errors and stops working during booting manager.
How to reproduce it (as minimally and precisely as possible):
Anything else we need to know?:
Environment:
kubectl version
):git describe --tags --dirty --always
):cat /etc/os-release
):uname -a
):The text was updated successfully, but these errors were encountered: