Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hardcoded macvlan parent interface inside centos template #7392

Closed
Colstuwjx opened this issue Mar 22, 2021 · 3 comments · Fixed by #7401
Closed

Hardcoded macvlan parent interface inside centos template #7392

Colstuwjx opened this issue Mar 22, 2021 · 3 comments · Fixed by #7401
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@Colstuwjx
Copy link
Contributor

We've been hardcoded the parent interface name inside the centos template, see this line, should use var macvlan_interface.

Environment:

  • Cloud provider or hardware configuration:

  • OS (printf "$(uname -srm)\n$(cat /etc/os-release)\n"):

  • Version of Ansible (ansible --version):

  • Version of Python (python --version):

Kubespray version (commit) (git rev-parse --short HEAD):
6d9ed39 ( latest )

Network plugin used:
macvlan

Full inventory with variables (ansible -i inventory/sample/inventory.ini all -m debug -a "var=hostvars[inventory_hostname]"):

Command used to invoke ansible:

Output of ansible run:

Anything else do we need to know:

@Colstuwjx Colstuwjx added the kind/bug Categorizes issue or PR as related to a bug. label Mar 22, 2021
@floryut
Copy link
Member

floryut commented Mar 23, 2021

@Colstuwjx Indeed, thanks for reporting, would you care to open up a PR or do you want us to to provide the fix ?

@Colstuwjx
Copy link
Contributor Author

would you care to open up a PR or do you want us to to provide the fix ?

Yes, I put my hands up while we're looking for maintainers, and this is the first PR #7401 for macvlan :)

@floryut
Copy link
Member

floryut commented Mar 24, 2021

would you care to open up a PR or do you want us to to provide the fix ?

Yes, I put my hands up while we're looking for maintainers, and this is the first PR #7401 for macvlan :)

Indeed, thank you for that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants