create a separated debuggable scheduler container #350

YamasouA · 2024-04-29T15:31:47Z

What type of PR is this?

/area simulator
/kind cleanup

What this PR does / why we need it:

I try to Separate API endpoints and Scheduler.
This PR can build debuggablescheduler Pod.
(But still not work. Only build)
After this PR I try to delete scheduler functions from Server and change endpoints functions to operate scheduler Pod.

Which issue(s) this PR fixes:

Fixes #318

Special notes for your reviewer:

/label tide/merge-method-squash

k8s-ci-robot · 2024-04-29T15:31:56Z

Hi @YamasouA. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

sanposhiho

/ok-to-test

Will take a look during GW

sanposhiho · 2024-05-02T11:54:20Z

simulator/pkg/debuggablescheduler/debuggable_scheduler.go

@@ -49,7 +49,7 @@ func CreateOptionForOutOfTreePlugin(outOfTreePluginRegistry runtime.Registry, pl

 var versionedcfg *v1.KubeSchedulerConfiguration
 var err error
- if configFile == nil {
+ if configFile == nil || *configFile == "" {


Can you make a separate PR for this line change?

I separate PR.
fix this PR.
60eff56
configFIle fix PR.
#351

sanposhiho

/ok-to-test
/retitle create a separated debuggable scheduler container

simulator/Makefile

simulator/cmd/simulator/Dockerfile

sanposhiho

can you also modify -
https://github.com/kubernetes-sigs/kube-scheduler-simulator/blob/48bdaf9be828b710539a9b60fc844cdcb7710c6a/simulator/docs/running-simulator.md

This reverts commit 638c117.

sanposhiho · 2024-05-05T00:40:07Z

simulator/docs/running-simulator.md

Replace L1-L8 with -

## Running simulator The simulator requires docker installed in your laptop. We have [docker-compose.yml](../../docker-compose.yml) to run the simulator easily.

I replaced text
9f03809

sanposhiho · 2024-05-05T00:40:32Z

simulator/cmd/scheduler/scheduler.go

+func main() {
+ command, cancelFn, err := debuggablescheduler.NewSchedulerCommand()
+ if err != nil {
+ klog.Info(fmt.Sprintf("failed to build the scheduler command: %+v", err))


Suggested change

klog.Info(fmt.Sprintf("failed to build the scheduler command: %+v", err))

klog.Info(fmt.Sprintf("failed to build the debuggablescheduler command: %+v", err))

sanposhiho · 2024-05-05T00:41:59Z

/kind feature

sanposhiho

/lgtm
/approve

Thanks :)

k8s-ci-robot · 2024-05-06T13:17:15Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sanposhiho, YamasouA

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [sanposhiho]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

YamasouA added 2 commits April 24, 2024 23:16

build Scheduler Pod

28f22b6

add local build

2f52e23

k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 29, 2024

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 29, 2024

k8s-ci-robot requested a review from 196Ikuchil April 29, 2024 15:31

k8s-ci-robot added the sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. label Apr 29, 2024

k8s-ci-robot requested a review from sanposhiho April 29, 2024 15:31

k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 29, 2024

YamasouA added 3 commits April 30, 2024 00:33

fix tweak

021bdfc

scheduler pod can compose up

5e4d725

fix env name

d0e1a24

YamasouA marked this pull request as ready for review May 1, 2024 15:05

k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 1, 2024

sanposhiho reviewed May 2, 2024

View reviewed changes

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 2, 2024

sanposhiho reviewed May 2, 2024

View reviewed changes

revert configfile empty case

60eff56

sanposhiho reviewed May 4, 2024

View reviewed changes

simulator/Makefile Outdated Show resolved Hide resolved

simulator/cmd/simulator/Dockerfile Outdated Show resolved Hide resolved

k8s-ci-robot changed the title ~~build scheduler pod~~ create a separated debuggable scheduler container May 4, 2024

YamasouA added 2 commits May 4, 2024 18:17

fix simulator Dockerfile path in cloudbuild.yaml

44cf8bd

delete start make rule in simulator/Makefile

11e2311

sanposhiho reviewed May 4, 2024

View reviewed changes

delete text which describe Running simulator without docker

638c117

k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 4, 2024

Revert "delete text which describe Running simulator without docker"

e2b0338

This reverts commit 638c117.

k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels May 4, 2024

delete text which describe Running simulator without docker

9faf951

sanposhiho reviewed May 5, 2024

View reviewed changes

k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label May 5, 2024

YamasouA added 2 commits May 6, 2024 21:56

fix doc/runnning-simulator

9f03809

fix klog text (scheduler -> debuggablescheduler)

0320da3

k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 6, 2024

sanposhiho approved these changes May 6, 2024

View reviewed changes

k8s-ci-robot assigned sanposhiho May 6, 2024

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 6, 2024

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 6, 2024

k8s-ci-robot merged commit 729dc18 into kubernetes-sigs:master May 6, 2024
5 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

create a separated debuggable scheduler container #350

create a separated debuggable scheduler container #350

YamasouA commented Apr 29, 2024 •

edited

k8s-ci-robot commented Apr 29, 2024

sanposhiho left a comment

sanposhiho May 2, 2024

YamasouA May 2, 2024

sanposhiho left a comment

sanposhiho left a comment

sanposhiho May 5, 2024

YamasouA May 6, 2024

sanposhiho May 5, 2024

sanposhiho commented May 5, 2024

sanposhiho left a comment

k8s-ci-robot commented May 6, 2024

	klog.Info(fmt.Sprintf("failed to build the scheduler command: %+v", err))
	klog.Info(fmt.Sprintf("failed to build the debuggablescheduler command: %+v", err))

create a separated debuggable scheduler container #350

create a separated debuggable scheduler container #350

Conversation

YamasouA commented Apr 29, 2024 • edited

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

k8s-ci-robot commented Apr 29, 2024

sanposhiho left a comment

Choose a reason for hiding this comment

sanposhiho May 2, 2024

Choose a reason for hiding this comment

YamasouA May 2, 2024

Choose a reason for hiding this comment

sanposhiho left a comment

Choose a reason for hiding this comment

sanposhiho left a comment

Choose a reason for hiding this comment

sanposhiho May 5, 2024

Choose a reason for hiding this comment

YamasouA May 6, 2024

Choose a reason for hiding this comment

sanposhiho May 5, 2024

Choose a reason for hiding this comment

sanposhiho commented May 5, 2024

sanposhiho left a comment

Choose a reason for hiding this comment

k8s-ci-robot commented May 6, 2024

YamasouA commented Apr 29, 2024 •

edited