Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AWS][Feature/Enhancement] Make suitableZones select only one Hosted Zone to create the Route53 records (even if it's public or private) #4454

Open
leonardocaylent opened this issue May 9, 2024 · 0 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@leonardocaylent
Copy link
Contributor

Previous context needed:
The issue: link
This Pull Request: link

Current behavior:
User has 3 hosted zones in AWS:
Public: mydomain.com
Private: internal.mydomain.com
Private: us-west-2.internal.mydomain.com

User creates an ingress with host: testdeploy.us-west-2.internal.mydomain.com
One A record to the AWS Load Balancer is created on each of the 3 Hosted Zones to k8s-ingress-1234abcd.us-west-2.elb.amazonaws.com with the corresponding 2 TXT records.

Desired behavior:
The external-dns controller should detect that the record is only wanted on the us-west-2.internal.mydomain.com Hosted Zone in this case.

Discussion:
This will be done modifying the current function suitableZones on the aws.go provider. With the addition of rolling back the fix for overlapping zones and a regression to check that:

  1. Users that update to the new version of external-dns will plan to delete the unused Route53 Records
  2. Users that start using external-dns on the new version won't be affected at all
  3. Try to detect use cases where a feature flag is needed to keep the original behavior (We really don't want to do this but if there are use cases for this we'll need to think about a solution for this)

cc: @Raffo @mloiseleur

@leonardocaylent leonardocaylent added the kind/feature Categorizes issue or PR as related to a new feature. label May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

1 participant