-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KCP: add condition to surface remediation state #8188
Comments
/triage accepted |
This issue has not been updated in over 1 year, and should be re-triaged. You can:
For more details on the triage process, see https://www.kubernetes.dev/docs/guide/issue-triage/ /remove-triage accepted |
/priority important-longterm |
/assign |
Current state is:
One option we might consider is to issue a patch to remove the annotation immediately after create, so we can further reduc the risk of a controller crash happening in between |
I wonder if we can just add some additional logic to automatically drop the annotation when we detect the remediation is done, e.g.
|
ACK, I will take a look |
We recently extended KCP remediation in #7963.
Goal of this issue is to add a condition to KCP to surface the state of the remedation.
The condition should help to debug issues in remedation. During PR review we identified a deadlock which should very rarely happen:
For now we added a log message, but it would be easier for users if they can see the status / progress of the remediation in a condition.
/kind feature
The text was updated successfully, but these errors were encountered: