Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add presubmit check to prevent accidental go directive bump #2810

Closed
sbueringer opened this issue Mar 12, 2024 · 5 comments · Fixed by #3004
Closed

Add presubmit check to prevent accidental go directive bump #2810

sbueringer opened this issue Mar 12, 2024 · 5 comments · Fixed by #3004
Assignees
@adityabhatia
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@sbueringer
Copy link
Member

sbueringer commented Mar 12, 2024 •
edited

In CAPV we only bump the go directive in go.mod files on the main branch.

While we bump the Go minor version that we build release branches with we never bump the go directive there.

This issue is about adding a presubmit check to ensure we don't accidentally bump it.

This can be implemented by adding a new verify-go-directive Makefile target (prior art: https://github.com/kubernetes/utils/pull/306/files) and then adding it to the verify target we already run in CI.

For more context, see: kubernetes/kubernetes#123744 and kubernetes-sigs/cluster-api#10258
@sbueringer
Copy link
Member Author

/triage accepted
/help wanted

@k8s-ci-robot k8s-ci-robot added the triage/accepted Indicates an issue or PR is ready to be actively worked on. label Mar 12, 2024
@MadhavJivrajani
Copy link

/help

@k8s-ci-robot
Copy link
Contributor

@MadhavJivrajani:
This request has been marked as needing help from a contributor.

Guidelines

Please ensure that the issue body includes answers to the following questions:

  • Why are we solving this issue?
  • To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
  • Does this issue have zero to low barrier of entry?
  • How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Mar 12, 2024
@adityabhatia
Copy link
Contributor

/assign

@sbueringer
Copy link
Member Author

@adityabhatia Still on your radar? :)

@adityabhatia adityabhatia mentioned this issue May 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adityabhatia adityabhatia

Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

🌱 add Go directive check as Makefile target adityabhatia/cluster-api-provider-vsphere
4 participants
@sbueringer @adityabhatia @MadhavJivrajani @k8s-ci-robot