-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check if e2e upgrade tests should consider adding coredns and etcd upgrade #2748
Comments
Not sure if I understand the issue correctly. As of now we don't set the env variables in CAPV upgrade tests. I think it's not strictly necessary as core CAPI already ensures we can upgrade to the correct etcd / CoreDNS versions. If it's important for us that our CAPV e2e tests upgrade to the same versions tested by upstream then we should simply introduce it the same way as in core CAPI. |
Yeah, we've been unsure if we actually need this in CAPV, so more of a placeholder to not forget about it and think it through once. |
/kind feature
Describe the solution you'd like
Currently the upgrade tests for CAPV only consider upgrading the k8s parts.
In CAPI we also upgrade coredns and etcd (when the default version changes) using the variables
ETCD_VERSION_UPGRADE_TO
andCOREDNS_VERSION_UPGRADE_TO
.Anything else you would like to add:
Maybe this already happens automatically, but we should check it and consider adding it if its not happening to stick to the combination tested on upstream kubernetes.
Environment:
The text was updated successfully, but these errors were encountered: