Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if e2e upgrade tests should consider adding coredns and etcd upgrade #2748

Open
chrischdi opened this issue Feb 16, 2024 · 2 comments
Open
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@chrischdi
Copy link
Member

/kind feature

Describe the solution you'd like

Currently the upgrade tests for CAPV only consider upgrading the k8s parts.

In CAPI we also upgrade coredns and etcd (when the default version changes) using the variables ETCD_VERSION_UPGRADE_TO and COREDNS_VERSION_UPGRADE_TO.

Anything else you would like to add:

Maybe this already happens automatically, but we should check it and consider adding it if its not happening to stick to the combination tested on upstream kubernetes.

Environment:

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Feb 16, 2024
@sbueringer
Copy link
Member

sbueringer commented Mar 13, 2024

Not sure if I understand the issue correctly.

As of now we don't set the env variables in CAPV upgrade tests. I think it's not strictly necessary as core CAPI already ensures we can upgrade to the correct etcd / CoreDNS versions.

If it's important for us that our CAPV e2e tests upgrade to the same versions tested by upstream then we should simply introduce it the same way as in core CAPI.
(Just a bit of additional work to ensure we configure this variables correctly, but we can copy that more or less from core CAPI)

@chrischdi
Copy link
Member Author

Yeah, we've been unsure if we actually need this in CAPV, so more of a placeholder to not forget about it and think it through once.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

3 participants