Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use upstream Cluster API .golangci.yaml #623

Open
cprivitere opened this issue Aug 7, 2023 · 0 comments
Open

Use upstream Cluster API .golangci.yaml #623

cprivitere opened this issue Aug 7, 2023 · 0 comments
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines.

Comments

@cprivitere
Copy link
Member

We should update our .golangci.yaml file to be more inline with upstream. It'll help make sure our package aliases are the same as the ones they use as well as enable better configs for things like gocritic which have caught at least one error in our code so far.

One discussion that I'd like to hear from others on is if we should keep the current strategy of only excluding problematic linters and otherwise including new linters golangci adds by default. Upstream instead only enables linters that they want/know work well. What do people want? Easiest thing to do is make it look as much as upstream as possible.

/kind feature

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Aug 7, 2023
@cprivitere cprivitere added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. and removed kind/feature Categorizes issue or PR as related to a new feature. labels Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines.
Projects
None yet
Development

No branches or pull requests

2 participants