-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"log.SetLogger(...) was never called" warning in controller tests #2018
Comments
@mdbooth can I assign this to myself, I might have a working version here for capm3 metal3-io/cluster-api-provider-metal3#1658 |
Be my guest! I was noodling something in #2019 but it didn't seem to work. I'll close it. |
/assign |
Thanks @kashifest for your contributions, they are very appreciated! |
I don't think so because the dates don't line up. That said, I can't reproduce this now and I don't see it in any recent CI output. Spooky 👻 I think I'll just close it. Sorry if you spent much time on this! |
No worries, it could be that you saw it in some release branch test where the fix was not cherry-picked. |
/kind bug
We frequently (always?) see this scary warning in CI out of the
-test
job:The text was updated successfully, but these errors were encountered: