Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to Shutdown VM before deleting it #1973

Open
shaardie opened this issue Mar 27, 2024 · 1 comment
Open

Option to Shutdown VM before deleting it #1973

shaardie opened this issue Mar 27, 2024 · 1 comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@shaardie
Copy link
Contributor

/kind feature

Describe the solution you'd like

I think the teardown process of VMs would benefit from an option to shutdown the OpenStack Machine before deleting it. This way it would be possible to benefit from teardown process in the VMs itself. Myself encountered this problem with NVIDIA licensees, which are borrowed on VM startup, but never properly released, because the Service on the VM was never stopped properly and therefore had no chance of releasing the license.

I think on way of implementing this, would be to add something like an waitForShutdown to the OpenStackMachine CRD. It could be defaulted to 0s to keep the old behavior and it would be a single configuration to have the possibility to let the VM properly shutdown and have a timeout for the shutdown, so that it does not hang forever in an error case.

If you are interested in such a feature, I would be happy to help implementing it.

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Mar 27, 2024
@mdbooth
Copy link
Contributor

mdbooth commented Mar 27, 2024

Sounds useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
Status: Inbox
Development

No branches or pull requests

3 participants