Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support setting routeTables to virtualnetworkssubnets for AKS managed clusters #4665

Open
Tracked by #4866
staerion opened this issue Mar 21, 2024 · 5 comments
Open
Tracked by #4866
Labels
area/managedclusters Issues related to managed AKS clusters created through the CAPZ ManagedCluster Type kind/feature Categorizes issue or PR as related to a new feature.
Milestone

Comments

@staerion
Copy link

/kind feature

Describe the solution you'd like
This feature request applies to AKS managed clusters.

The capi azure provider can create virtualnetworks and subnets for AKS managed clusters. They can be configured under the field
AzureManagedControlPlane.spec.virtualNetwork.subnet. From this object you can configure the cidrBlock, name and optionally privateEndpoints and serviceEndpoints. In our use case we'd also like to configure a routeTable for the subnet. Currently this option is not support by capi azure provider.

Anything else you would like to add:
The aso controller itself does already have support for this option: https://azure.github.io/azure-service-operator/reference/network/v1api20201101/#network.azure.com/v1api20201101.VirtualNetworksSubnet

Environment:

  • cluster-api-provider-azure version: v1.14.0
  • Kubernetes version: (use kubectl version): 1.27.7
  • OS (e.g. from /etc/os-release): Ubuntu 22.04.4 LTS
@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Mar 21, 2024
@jackfrancis
Copy link
Contributor

cc @nojnhuh if you want to sanity check this scenario as available in your ASO AKS prototype

@nojnhuh
Copy link
Contributor

nojnhuh commented Mar 21, 2024

@jackfrancis Yes, this kind of thing is possible with my prototype. Sorry @staerion I don't have anything to show for that yet, but keep your eyes on Slack and the PR queue in the coming weeks.

@staerion
Copy link
Author

Great, thanksk for the heads up! We'll make sure to keep track of the slack channel and new releases.

@dtzar dtzar added the area/managedclusters Issues related to managed AKS clusters created through the CAPZ ManagedCluster Type label May 16, 2024
@dtzar
Copy link
Contributor

dtzar commented May 16, 2024

How would this work with CAPZ new ASO v2 API? @nojnhuh @nawazkh

@dtzar dtzar added this to the v1.16 milestone May 16, 2024
@nojnhuh
Copy link
Contributor

nojnhuh commented May 16, 2024

How would this work with CAPZ new ASO v2 API? @nojnhuh @nawazkh

You could add vnet and subnet resources to spec.resources of the AzureASOManagedCluster alongside the ResourceGroup and define them however you want:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/managedclusters Issues related to managed AKS clusters created through the CAPZ ManagedCluster Type kind/feature Categorizes issue or PR as related to a new feature.
Projects
Status: No status
Development

No branches or pull requests

5 participants