Add artifact streaming support for managed AKS

[paulapetri]

/kind feature

Describe the solution you'd like
Add support for Artifact Streaming for AKS managed services https://learn.microsoft.com/en-us/azure/aks/artifact-streaming

[CecileRobertMichon]

related to #2625 since this is a preview feature

[CecileRobertMichon]

/area managedclusters

[dtzar]

This theoretically should work now by enabling the preview API and the CAPZ patch mechanism to enable this feature. @paulapetri - would you like to try this out?

[dtzar]

Unfortunately, I don't see any diff in the asoctl yaml export after enabling this preview feature. So without the ASO diff, the ASO patch won't do anything of course. Using asoctl 2.6.0.

Here's what I ran:

asoctl import azure-resource /subscriptions/###/resourcegroups/argoaks/providers/Microsoft.ContainerService/managedClusters/argoaks -o argocluster-aso.yaml 
az aks nodepool update --resource-group argoaks --cluster-name argoaks --name pool1 --enable-artifact-streaming
asoctl import azure-resource /subscriptions/###/resourcegroups/argoaks/providers/Microsoft.ContainerService/managedClusters/argoaks -o argocluster-aso2.yaml 

Any ideas @matthchr ?

[matthchr]

artifact streaming is a property of the nodepool but you're importing the cluster.

You need to import the nodepool to see the diff.

Though, the diff will be:

spec:
    artifactStreamingProfile:
        enabled: true

I think.

[dtzar]

Thanks for the pointer! All I got was this from the ManagedClustersAgentPool:

---
apiVersion: containerservice.azure.com/v1api20231001
kind: ManagedClustersAgentPool
metadata:
  creationTimestamp: null
  name: pool1
spec:
  azureName: pool1
  count: 1
  enableAutoScaling: false
  enableFIPS: false
  kubeletDiskType: OS
  maxPods: 30
  mode: User
  orchestratorVersion: 1.28.5
  osDiskSizeGB: 128
  osDiskType: Managed
  osSKU: Ubuntu
  osType: Linux
  powerState:
    code: Running
  scaleDownMode: Delete
  type: Microsoft.ContainerService/managedClusters/agentPools
  upgradeSettings:
    maxSurge: 10%
  vmSize: Standard_B2s
---

[matthchr]

It looks like asoctl always imports using the latest GA version we support

Which is probably a reasonable default but we might need to be able to override it. cc @theunrepentantgeek

In any case, I don't' think you specifically need asoctl to define the diff, it's just a convenient way to see what you need to add, right?

See here for the expected shape. As I said it's:

apiVersion: containerservice.azure.com/v1api20231102preview
kind: ManagedClustersAgentPool
spec:
    artifactStreamingProfile:
        enabled: true

[theunrepentantgeek]

@matthchr wrote

It looks like asoctl always imports using the latest GA version we support

That's correct; we can't tell from the resource which api-version was used for creation; selecting the latest stable release seemed like a sensible default.

One way to address this might be to add a --prefer-preview-versions flag with global effect.

Another would be to offer full control, resource-by-resource or maybe group-by-group, though that would be more complex.

I'll log an issue to track this.

[dtzar]

Thanks Matt and Bevan! I think a generic flag like --prefer-preview-versions would work great and no need for more granular especially since you're already specifically asking for import of a specific resource.

Tangent related feature ask would be to import all dependent resources (e.g. import ManagedClusters also imports ManagedClustersAgentPool)

[dtzar]

In any case, I don't' think you specifically need asoctl to define the diff, it's just a convenient way to see what you need to add, right?

Right, code -d works perfect for diff.

[matthchr]

Tangent related feature ask would be to import all dependent resources (e.g. import ManagedClusters also imports ManagedClustersAgentPool)

Actually this should already be the behavior - I just forgot it when saying "you should just import the AgentPool". So my suspicion is that with the --prefer-preview-versions flag, your original command would've worked.