Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Graduate the garbage Collection feature #4397

Open
richardcase opened this issue Jul 13, 2023 · 15 comments · May be fixed by #4957
Open

Graduate the garbage Collection feature #4397

richardcase opened this issue Jul 13, 2023 · 15 comments · May be fixed by #4957
Assignees
@richardcase
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Milestone
v2.5.0

Comments

@richardcase
Copy link
Member

/kind feature

Describe the solution you'd like
We introduced GC in v1.5.0 in Aug 2022. I propose that we graduate this feature and enable it by default.

Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]

Environment:

  • Cluster-api-provider-aws version:
  • Kubernetes version: (use kubectl version):
  • OS (e.g. from /etc/os-release):
@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jul 13, 2023
@richardcase
Copy link
Member Author

/assign

@richardcase
Copy link
Member Author

/milestone v2.3.0

@k8s-ci-robot k8s-ci-robot added this to the v2.3.0 milestone Jul 13, 2023
@richardcase
Copy link
Member Author

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jul 19, 2023
@richardcase
Copy link
Member Author

/priority important-soon

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority labels Jul 19, 2023
@Ankitasw
Copy link
Member

Ankitasw commented Sep 5, 2023

@richardcase do we have a task list to track what all fixes should go as part of this?

@Fedosin
Copy link
Contributor

Fedosin commented Sep 7, 2023

@Ankitasw I think the remaining tasks are:

  1. Add validation for GC config (Add validation for GC tasks annotation #4485)
  2. Add awscli support for GC configuration.
  3. Update the docs.

Tell me if I missed something.

@richardcase
Copy link
Member Author

/milestone v2.4.0

@k8s-ci-robot k8s-ci-robot modified the milestones: v2.3.0, v2.4.0 Nov 16, 2023
@Ankitasw
Copy link
Member

Ankitasw commented Jan 11, 2024 •
edited

@Ankitasw I think the remaining tasks are:

Add validation for GC config (#4485)
Add awscli support for GC configuration.
Update the docs.
Tell me if I missed something.

@Fedosin would you be able to proceed with these tasks?

@richardcase
Copy link
Member Author

/unassign

@richardcase
Copy link
Member Author

/help

@k8s-ci-robot
Copy link
Contributor

@richardcase:
This request has been marked as needing help from a contributor.

Guidelines

Please ensure that the issue body includes answers to the following questions:

  • Why are we solving this issue?
  • To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
  • Does this issue have zero to low barrier of entry?
  • How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Jan 19, 2024
@richardcase richardcase removed this from the v2.4.0 milestone Jan 23, 2024
@k8s-triage-robot
Copy link

This issue is labeled with priority/important-soon but has not been updated in over 90 days, and should be re-triaged.
Important-soon issues must be staffed and worked on either currently, or very soon, ideally in time for the next release.

You can:

  • Confirm that this issue is still relevant with /triage accepted (org members only)
  • Deprioritize it with /priority important-longterm or /priority backlog
  • Close this issue with /close

For more details on the triage process, see https://www.kubernetes.dev/docs/guide/issue-triage/

/remove-triage accepted

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. and removed triage/accepted Indicates an issue or PR is ready to be actively worked on. labels Apr 22, 2024
@richardcase
Copy link
Member Author

/triage accepted
/priority important-soon

@k8s-ci-robot k8s-ci-robot added the triage/accepted Indicates an issue or PR is ready to be actively worked on. label Apr 22, 2024
@k8s-ci-robot k8s-ci-robot removed the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Apr 22, 2024
@richardcase
Copy link
Member Author

/milestone v2.5.0

@k8s-ci-robot k8s-ci-robot added this to the v2.5.0 milestone Apr 22, 2024
@richardcase
Copy link
Member Author

/assign
/lifecycle active

@k8s-ci-robot k8s-ci-robot added the lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. label Apr 26, 2024
@richardcase richardcase linked a pull request Apr 26, 2024 that will close this issue
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@richardcase richardcase

Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
Roadmap 2024
Status: In Progress
Milestone
v2.5.0
Development

Successfully merging a pull request may close this issue.

✨ feat: graduate the garbage collection feature richardcase/cluster-api-provider-aws
5 participants
@richardcase @Fedosin @k8s-ci-robot @k8s-triage-robot @Ankitasw