Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workflow for regular (nightly or weekly) releases #4949

Open
nrb opened this issue Apr 23, 2024 · 9 comments
Open

Add workflow for regular (nightly or weekly) releases #4949

nrb opened this issue Apr 23, 2024 · 9 comments
Labels
area/release Issues or PRs related to releasing priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@nrb
Copy link
Contributor

nrb commented Apr 23, 2024

#4748 automated releases with GoReleaser. We can build on this configuration by making regular releases via another workflow. These could be nightly or weekly, depending on CI availability.

This gives us more regular build signal, and versions that users can test out.

CAPV has weekly automated releases (that don't seem to get published), as does upstream CAPI.

These will need to be generated as pre-release GitHub releases to prevent clusterctl picking them up. So #4927 will need to be fixed first.

@k8s-ci-robot k8s-ci-robot added needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Apr 23, 2024
@nrb
Copy link
Contributor Author

nrb commented Apr 23, 2024

/triage accepted
/priority important-longterm
/area release

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. area/release Issues or PRs related to releasing and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority labels Apr 23, 2024
@nrb
Copy link
Contributor Author

nrb commented Apr 23, 2024

One thing that could be tricky here is solving where the container images associated with the release land. We likely will not be able to use kpromo on them, since that will require manual PR approvals.

Another challenge will be cleaning up the images; I don't think we want to keep all of them especially if there are nightly releases. We'll have to decide on how long we'll keep a nightly or weekly around once cut.

@damdo
Copy link
Member

damdo commented Apr 23, 2024

+1

We will also need to figure out whether we want to add them as actual draft releases in the Release section of the Repo, or if we can deal with this differently.
Also if we end up with doing draft releases, we would probably want to clean these up regularly too.

I would be interested in understanding how CAPV and upstream CAPI deals with this at the moment.

Maybe @sbueringer @chrischdi @fabriziopandini can provide some more details on how the process looks like there.

@sbueringer
Copy link
Member

We don't do actual releases. The GitHub action is just there to ensure the make target keeps working.

What we do though is publishing nightly manifests & images to GCS

@sbueringer
Copy link
Member

sbueringer commented Apr 23, 2024

Looked at the log of the jobs: https://storage.googleapis.com/kubernetes-jenkins/logs/cluster-api-provider-aws-push-images-nightly/1782680957447311360/artifacts/build.log

Looks pretty good already. I would just recommend to change the location of the manifests. See: kubernetes-sigs/cluster-api#10489
(we just did the same for CAPV)

I'll mention it in core CAPI office hours tomorrow, if you have some questions that you want to ask directly there.

@damdo
Copy link
Member

damdo commented Apr 24, 2024

@sbueringer I see, I didn't know that, thanks a lot!

As you suggested I opened: #4952
to move to the new bucket.

I will open a separate PR to improve the docs on how to use nightlies.

Thanks again!

@nrb
Copy link
Contributor Author

nrb commented Apr 29, 2024

See kubernetes-sigs/cluster-api#10521 also as we work towards this.

@damdo
Copy link
Member

damdo commented Apr 30, 2024

@nrb I think #4952 should take care of both nightly and other branches (releases, main) manifests.
Let's try and get that one merge, and we can iterate if that needs more work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/release Issues or PRs related to releasing priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

No branches or pull requests

4 participants