Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-think how we manage prerequisites in clusterawsadm (LFX Spring 2023 Mentorship) #3715

Open
richardcase opened this issue Sep 8, 2022 · 12 comments · May be fixed by #4909
Open

Re-think how we manage prerequisites in clusterawsadm (LFX Spring 2023 Mentorship) #3715

richardcase opened this issue Sep 8, 2022 · 12 comments · May be fixed by #4909
Assignees
@richardcase @Atharva-Shinde
Labels
area/clusterawsadm Issues or PRs related to clusterawsadm help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.

Comments

@richardcase
Copy link
Member

/kind feature
/area clusterawsadm

Describe the solution you'd like

Currently, we use clusterawsadm to create the AWS prerequisites (i.e. IAM stuff). This creates a Cloud Formation stack.

Users are running into issues with the clusterawsadm/cloud formation approach because CloudFormation is region specific but IAM is global. Customers end up in the position where the stacks are created in multiple regions but some fail as the IAM resources have been created by another stack in another reason. Other users have run into other issues with the cloud formation stack for various reasons.

Anything else you would like to add:
I personally think we should remove the use of Cloud Formation and look at another solution.

Environment:

  • Cluster-api-provider-aws version:
  • Kubernetes version: (use kubectl version):
  • OS (e.g. from /etc/os-release):
@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. area/clusterawsadm Issues or PRs related to clusterawsadm needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Sep 8, 2022
@soggiest
Copy link

I'm running into this same issue. Another user previously created CAPA IAM roles via clusterawsadm, however they didn't enable EKS so the appropriate roles don't exist. Subsequent bootstrap attempts with EKS enable fail because the cloudformation stack doesn't skip roles that already exists, instead it fails and rolls everything back.

@richardcase
Copy link
Member Author

/triage accepted
/priority important-soon
/help

@k8s-ci-robot
Copy link
Contributor

@richardcase:
This request has been marked as needing help from a contributor.

Guidelines

Please ensure that the issue body includes answers to the following questions:

  • Why are we solving this issue?
  • To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
  • Does this issue have zero to low barrier of entry?
  • How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

/triage accepted
/priority important-soon
/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority labels Oct 10, 2022
@richardcase richardcase mentioned this issue Jan 23, 2023
Open
@richardcase
Copy link
Member Author

We want to use this for the LFX Spring 23 program, so until that starts

/assign

@hackeramitkumar
Copy link
Member

@richardcase it's an interesting feature, I would like to contribute to this feature in the lfx spring mentorship.

@richardcase
Copy link
Member Author

The project is now listed:

https://mentorship.lfx.linuxfoundation.org/project/2d76dbe6-43eb-465e-a852-64b2e48f2c68

@guohaoyu110
Copy link

hi, @richardcase I am CS graduate student from USC. I am very interested in this project and have project experience with go, docker and kubernetes. I just applied to the LFX mentorship program. Could you give some suggestions on getting started on this project? Thank you.

@richardcase
Copy link
Member Author

@guohaoyu110 - thanks for your interest. Until the application window shuts and selection have been made it's best not to work on this issue. However, understanding go & kubernetes will really help if you are selected.

@richardcase
Copy link
Member Author

/retitle Re-think how we manage prerequisites in clusterawsadm (LFX Spring 2023 Mentorship)

@k8s-ci-robot k8s-ci-robot changed the title Re-think how we manage prerequisites in clusterawsadm Re-think how we manage prerequisites in clusterawsadm (LFX Spring 2023 Mentorship) Feb 8, 2023
@richardcase
Copy link
Member Author

The LFX application period is open until 14th Feb 2023. Applications are reviewed 15th-28th Feb.

@richardcase
Copy link
Member Author

The dates have slightly changed and applications are now open until 21st Feb. The full timeline can be seen here: https://github.com/cncf/mentoring/tree/main/lfx-mentorship/2023/01-Mar-May#term-01---2023-march---may

@dlipovetsky dlipovetsky mentioned this issue Mar 6, 2023
Open
@k8s-triage-robot
Copy link

This issue is labeled with priority/important-soon but has not been updated in over 90 days, and should be re-triaged.
Important-soon issues must be staffed and worked on either currently, or very soon, ideally in time for the next release.

You can:

  • Confirm that this issue is still relevant with /triage accepted (org members only)
  • Deprioritize it with /priority important-longterm or /priority backlog
  • Close this issue with /close

For more details on the triage process, see https://www.kubernetes.dev/docs/guide/issue-triage/

/remove-triage accepted

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. and removed triage/accepted Indicates an issue or PR is ready to be actively worked on. labels May 11, 2023
@Atharva-Shinde Atharva-Shinde mentioned this issue Sep 30, 2023
Closed
4 tasks
@Atharva-Shinde Atharva-Shinde linked a pull request Apr 4, 2024 that will close this issue
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@richardcase richardcase

@Atharva-Shinde Atharva-Shinde

Labels
area/clusterawsadm Issues or PRs related to clusterawsadm help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
Roadmap 2024
Status: Todo
Milestone
No milestone
7 participants
@richardcase @soggiest @guohaoyu110 @k8s-ci-robot @k8s-triage-robot @Atharva-Shinde @hackeramitkumar