Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Potential race when AWSCluster/AWSMachine reconciler exits before completion without an error #4876

Open
mdbooth opened this issue Mar 18, 2024 · 1 comment
Open

Potential race when AWSCluster/AWSMachine reconciler exits before completion without an error #4876

mdbooth opened this issue Mar 18, 2024 · 1 comment
Labels
kind/bug Categorizes issue or PR as related to a bug. needs-priority triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@mdbooth
Copy link

mdbooth commented Mar 18, 2024 •
edited

/kind bug

This is a real bug in CAPO which we have been hitting regularly in CI: kubernetes-sigs/cluster-api-provider-openstack#1954

The commit which added the offending predicates in CAPO noted that they were copying a pattern from CAPA, and you also still have them.

It may not currently be a real bug in CAPA, but it's a surprising pattern which violates the principle of least astonishment, so it may turn into a real bug in the future.
@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 18, 2024
@AndiDog
Copy link
Contributor

AndiDog commented Mar 19, 2024

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Categorizes issue or PR as related to a bug. needs-priority triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mdbooth @AndiDog @k8s-ci-robot