-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Customresource spec.deployment
is only a limited subset
#310
Comments
/triage accepted |
This can be added to our deployment spec in provider's API |
Hey @johanjk @alexander-demicev. I've been taking a look at this and, assuming the fields of interest are the ones in DeploymentSpec here, there are a few of them that are not optional. Is it expected to support overriding only a selection of these fields or would it be useful to have this struct embedded inline and have access to all fields considering some of them would be required? |
@salasberryfin We had a bad experience with embedding structures in API, if something changes in the structure our API can get broken |
When setting overrides on the deployment, only the following parameters are available:
I would like to be able to configure, amongst other things
spec.strategy
. Could the operator allow the full deployment spec to be configured?/kind feature
The text was updated successfully, but these errors were encountered: