-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CRDs aren't inside the crds
folder
#282
Comments
This issue is currently awaiting triage. If CAPI Operator contributors determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hi, thanks for opening the issue. Unfortunately, it's not possible to upgrade CRDs if they are located in the CRD folder https://helm.sh/docs/chart_best_practices/custom_resource_definitions/#some-caveats-and-explanations |
Yes and no, for manual workflows, like But using gitops it's easily possible, see https://fluxcd.io/flux/components/helm/helmreleases/#crds |
Ideally, we want to support |
I understand, but doing it this way breaks other stuff, even inside the chart itself, as shown in #283 Currently, you can't really use this chart in a gitops way because of this CRD stuff. If the CRDs were inside the
Not really, the problem is explicitly that the CRDs aren't in the EDIT: maybe miscommunication, but it's ok to have the CRDs in another chart, as long as it's in the |
We also have a use case where we might template CRDs, some users would like to avoid using cert-manager and prefer a custom solution, that will require removing/replacing cert-manager annotation from CRDs. |
What are you templating? 🤔
Exactly this isn't even possible, as the cert-manager CRDs are always created Annotations on CRDs? Are you sure you don't mean on CRs? |
Yes, we set CA injector annotation on the CRD itself https://cert-manager.io/docs/concepts/ca-injector/ |
For that special use-case I would, from your perspective, just decide on a name and hardcode that. IMHO one should mainly support the best ways, which is of course subjective, and the most wanted and easy to achieve other ways. |
Hi all,
As cwrau says, flux can create/replace crds https://fluxcd.io/flux/components/helm/helmreleases/#crds So I wonder about the benefit of using the capi operator rather than clusterctl ? |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues. This bot triages un-triaged issues according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues. This bot triages un-triaged issues according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
What is the current status of this issue? |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages issues according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /close not-planned |
@k8s-triage-robot: Closing this issue, marking it as "Not Planned". In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Anything else you would like to add:
This goes against helm best-practices. I understand that for non-gitops workflows having the CRDs inside the
templates
folder (with anif
!) is necessary, but they should still be inside thecrds
folder for normal operations, like not needingpost-*
hooks for creating CRs, and gitops for CRD upgradesEnvironment:
kubectl version
): N/A/etc/os-release
): N/A/kind bug
[One or more /area label. See https://github.com/kubernetes-sigs/cluster-api-operator/labels?q=area for the list of labels]
The text was updated successfully, but these errors were encountered: