[Fix] Continue reconcile LB if error is 403/404 #4260

lzhecheng · 2023-07-07T09:59:59Z

What type of PR is this?

/kind bug

What this PR does / why we need it:

[Fix] Continue reconcileLB if error is 403/404. When deleting an LB, error like 403/404 should not stop the reconcile process.

Which issue(s) this PR fixes:

Fixes #933

Special notes for your reviewer:

Does this PR introduce a user-facing change?

[Fix] Continue reconcileLB if error is 403/404. When deleting an LB, error like 403/404 should not stop the reconcile process.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

k8s-ci-robot · 2023-07-07T10:00:04Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lzhecheng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [lzhecheng]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

feiskyer · 2023-07-11T14:06:15Z

pkg/provider/azure_loadbalancer.go

@@ -1660,7 +1660,7 @@ func (az *Cloud) reconcileLoadBalancer(clusterName string, service *v1.Service,
 for i := range toDeleteConfigs {
 fipConfigToDel := toDeleteConfigs[i]
 err := az.reconcilePrivateLinkService(clusterName, service, &fipConfigToDel, false /* wantPLS */)
- if err != nil {
+ if err != nil && !retry.HasStatusForbiddenOrIgnoredError(err) {


Could we skip 403/404 only for cleanup operation? For create operation, 403/404 should not be skipped.

Thanks for reminding me.
Compared to last commit, I use HasStatusForbiddenOrIgnoredError only for PLS and backend pool because I think the issue is about these resources instead of those LB's resources like FIP.
Code updated.

pkg/provider/azure_loadbalancer.go

When deleting an LB, error like 403/404 should not stop the reconcile process. Signed-off-by: Zhecheng Li <[email protected]>

lzhecheng · 2023-07-12T06:55:30Z

/retest

nilo19 · 2023-07-13T08:27:38Z

Why do we want to ignore 403?

nilo19 · 2023-07-13T08:32:41Z

pkg/provider/azure_loadbalancer_backendpool.go

@@ -614,8 +618,11 @@ func (bi *backendPoolTypeNodeIP) ReconcileBackendPools(clusterName string, servi
 klog.V(2).Infof("bi.ReconcileBackendPools for service (%s) and vmSet (%s): ensuring the LB is decoupled from the VMSet", serviceName, vmSetName)
 shouldRefreshLB, err = bi.VMSet.EnsureBackendPoolDeleted(service, lbBackendPoolIDsSlice, vmSetName, lb.BackendAddressPools, true)
 if err != nil {
- klog.Errorf("bi.ReconcileBackendPools for service (%s): failed to EnsureBackendPoolDeleted: %s", serviceName, err.Error())
- return false, false, false, err
+ if !retry.HasStatusForbiddenOrIgnoredError(err) {


ensureBackendPoolDeleted decouples vmss and vm from backend pool instead of deleting the backend pool. I am not sure if it will return 404 when updating an non-existent vmss/vmssvm.

I think it will return 404 when it vmssCache.Get() with non-existing vmss.

cloud-provider-azure/pkg/provider/azure_vmss.go

Line 1645 in 5d65ed3

cachedUniform, err := ss.vmssCache.Get(consts.VMSSKey, azcache.CacheReadTypeDefault)

Can you point out where the 404 can be returned? I think the LIST calls should not generate a 404 error.

nilo19 · 2023-07-13T08:37:24Z

pkg/provider/azure_privatelinkservice.go

- if deleteErr != nil {
- klog.Errorf("reconcilePrivateLinkService for service(%s): deletePLS for frontEnd(%s) failed: %v", serviceName, pointer.StringDeref(fipConfigID, ""), err)
- return deleteErr.Error()
+ if !retry.HasStatusForbiddenOrIgnoredError(err) {


It seems it will not return not found error if failed to get the pls by fipConfigID?

Yes, it only leaves a warning. I think it is ok because it is in if !wantPLS condition.

If the condition will not met, why bother to add so many lines of code for a scenario that will never happen?

lzhecheng · 2023-07-14T08:20:36Z

Why do we want to ignore 403?

I see 404 is handled with 403, "when AuthorizationFailed is reported from Azure API", so I followed the logic.

cloud-provider-azure/pkg/retry/azure_error.go

Lines 305 to 308 in 3ea02d9

 if rerr.HTTPStatusCode == http.StatusForbidden { 

 klog.V(3).Infof("Ignoring StatusForbidden error: %w", rerr) 

 return nil 

 }

nilo19 · 2023-07-24T13:54:38Z

The function is designed for delete operations and is not being used anymore.

k8s-ci-robot · 2023-10-28T03:31:00Z

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot · 2023-12-18T13:21:10Z

@lzhecheng: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-cloud-provider-azure-unit	`4e985a9`	link	true	`/test pull-cloud-provider-azure-unit`
pull-cloud-provider-azure-e2e-ccm-vmss-multi-slb-capz	`4e985a9`	link	true	`/test pull-cloud-provider-azure-e2e-ccm-vmss-multi-slb-capz`
pull-cloud-provider-azure-e2e-ccm-vmss-ip-lb-capz	`4e985a9`	link	true	`/test pull-cloud-provider-azure-e2e-ccm-vmss-ip-lb-capz`
pull-cloud-provider-azure-e2e-ccm-vmss-capz	`4e985a9`	link	true	`/test pull-cloud-provider-azure-e2e-ccm-vmss-capz`
pull-cloud-provider-azure-e2e-ccm-vmssflex-capz	`4e985a9`	link	true	`/test pull-cloud-provider-azure-e2e-ccm-vmssflex-capz`
pull-cloud-provider-azure-e2e-capz	`4e985a9`	link	true	`/test pull-cloud-provider-azure-e2e-capz`
pull-cloud-provider-azure-e2e-ccm-capz	`4e985a9`	link	true	`/test pull-cloud-provider-azure-e2e-ccm-capz`
pull-cloud-provider-azure-e2e-ccm-vmss-shared-probe-capz	`4e985a9`	link	true	`/test pull-cloud-provider-azure-e2e-ccm-vmss-shared-probe-capz`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

k8s-triage-robot · 2024-03-17T13:36:58Z

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle stale
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot · 2024-04-16T13:51:55Z

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle rotten
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot · 2024-05-16T14:19:18Z

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Reopen this PR with /reopen
Mark this PR as fresh with /remove-lifecycle rotten
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

k8s-ci-robot · 2024-05-16T14:19:23Z

@k8s-triage-robot: Closed this PR.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied

After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied

After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Reopen this PR with /reopen

Mark this PR as fresh with /remove-lifecycle rotten

Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. labels Jul 7, 2023

k8s-ci-robot requested a review from feiskyer July 7, 2023 10:00

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 7, 2023

k8s-ci-robot requested a review from MartinForReal July 7, 2023 10:00

k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 7, 2023

feiskyer reviewed Jul 11, 2023

View reviewed changes

pkg/provider/azure_loadbalancer.go Outdated Show resolved Hide resolved

lzhecheng force-pushed the ensure-lb-delete-continue-if-resource-not-exist branch from 4bb55d0 to 00ade9c Compare July 12, 2023 05:30

k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 12, 2023

[Fix] Continue reconcile LB if error is 403/404

4e985a9

When deleting an LB, error like 403/404 should not stop the reconcile process. Signed-off-by: Zhecheng Li <[email protected]>

lzhecheng force-pushed the ensure-lb-delete-continue-if-resource-not-exist branch from 00ade9c to 4e985a9 Compare July 12, 2023 05:37

nilo19 reviewed Jul 13, 2023

View reviewed changes

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 28, 2023

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 17, 2024

k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Apr 16, 2024

k8s-ci-robot closed this May 16, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Fix] Continue reconcile LB if error is 403/404 #4260

[Fix] Continue reconcile LB if error is 403/404 #4260

lzhecheng commented Jul 7, 2023

k8s-ci-robot commented Jul 7, 2023

feiskyer Jul 11, 2023

lzhecheng Jul 12, 2023

lzhecheng commented Jul 12, 2023

nilo19 commented Jul 13, 2023

nilo19 Jul 13, 2023

lzhecheng Jul 24, 2023

nilo19 Jul 24, 2023

nilo19 Jul 13, 2023

lzhecheng Jul 24, 2023

nilo19 Jul 24, 2023

lzhecheng commented Jul 14, 2023

nilo19 commented Jul 24, 2023

k8s-ci-robot commented Oct 28, 2023

k8s-ci-robot commented Dec 18, 2023

k8s-triage-robot commented Mar 17, 2024

k8s-triage-robot commented Apr 16, 2024

k8s-triage-robot commented May 16, 2024

k8s-ci-robot commented May 16, 2024

[Fix] Continue reconcile LB if error is 403/404 #4260

[Fix] Continue reconcile LB if error is 403/404 #4260

Conversation

lzhecheng commented Jul 7, 2023

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

k8s-ci-robot commented Jul 7, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lzhecheng commented Jul 12, 2023

nilo19 commented Jul 13, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lzhecheng commented Jul 14, 2023

nilo19 commented Jul 24, 2023

k8s-ci-robot commented Oct 28, 2023

k8s-ci-robot commented Dec 18, 2023

k8s-triage-robot commented Mar 17, 2024

k8s-triage-robot commented Apr 16, 2024

k8s-triage-robot commented May 16, 2024

k8s-ci-robot commented May 16, 2024