Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Observability #1575

Open
3 tasks
zarvd opened this issue Apr 26, 2022 · 4 comments
Open
3 tasks

Improve Observability #1575

zarvd opened this issue Apr 26, 2022 · 4 comments
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@zarvd
Copy link
Contributor

zarvd commented Apr 26, 2022

Problems:

Logging:

  • mixed-use plain-text logging and structural logging
  • coverage
  • convention

Goals

scope: logging/metrics/tracing

  • standardize convention and improve the coding experience
  • improve debug efficiency

Refs

Logging:

To-do

Logging

  • Adopt structural logging
  • Adopt logr interface
  • Adopt JSON format? (easy to parse)

TBD: require discussion?

Tracking Tasks
@zarvd zarvd mentioned this issue Apr 26, 2022
Closed
@nilo19 nilo19 added the good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. label Jun 27, 2022
@ZombieMInd
Copy link

Why is #1494 closed? Does this issue require another approach?

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 10, 2022
@feiskyer feiskyer removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 11, 2022
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 8, 2023
@Sajiyah-Salat
Copy link

is this pr still valid?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@feiskyer @zarvd @k8s-ci-robot @ZombieMInd @nilo19 @k8s-triage-robot @Sajiyah-Salat