Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Prometheus Metrics #3716

Open
kevarr opened this issue May 24, 2024 · 3 comments
Open

Improve Prometheus Metrics #3716

kevarr opened this issue May 24, 2024 · 3 comments
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.

Comments

@kevarr
Copy link

kevarr commented May 24, 2024

Is your feature request related to a problem?

I couldn't find any documentation for what metrics the "metrics-server" port exposes.

Additionally, I couldn't configure the Helm Chart to not scrape these metrics, as my scrape_configs are looking at the prometheus.io/* annotations and these cannot be removed without enabling a ServiceMonitor.

Describe the solution you'd like

  • Helm Chart capability to remove prometheus.io/* annotations without enabling the ServiceMonitor
  • Documentation on available controller metrics
  • Metrics for reconciles (totals, errors successes), invalid configurations

Describe alternatives you've considered

N/A

@kevarr kevarr changed the title Prometheus Metrics Prometheus Metrics (Helm/Docs) May 24, 2024
@kevarr
Copy link
Author

kevarr commented May 24, 2024

Related #3244

@kevarr kevarr changed the title Prometheus Metrics (Helm/Docs) Improve Prometheus Metrics May 24, 2024
@shraddhabang shraddhabang added the kind/feature Categorizes issue or PR as related to a new feature. label May 29, 2024
@huangm777
Copy link

Thank you for raising the issue! We will be taking a look at it, and of course we also welcome any community contributions to address the issue as well.

@shraddhabang shraddhabang added the good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. label May 29, 2024
@kevarr
Copy link
Author

kevarr commented May 30, 2024

Thanks @huangm777, ended up finding some metrics I could use, namely the aws_api ones. Still I think I would benefit from having some of these documented. When I find time I'll try to open a PR for this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

3 participants