-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inconsistency across docs/code for aws-load-balancer-manage-backend-security-group-rules #3660
Comments
Issue kubernetes-sigs#3660. Signed-off-by: Raul Gutierrez Segales <[email protected]>
Issue kubernetes-sigs#3660. Signed-off-by: Raul Gutierrez Segales <[email protected]>
Ok I see the issue now, it's |
@rgs1, yes your understanding is correct. If the user specifies the self-managed SG through |
In the annotations docs it says that
aws-load-balancer-manage-backend-security-group-rules
defaults to true:https://github.com/kubernetes-sigs/aws-load-balancer-controller/blame/main/docs/guide/service/annotations.md#L52
However in the security docs the writing implies that it needs to be explicitly set:
https://github.com/kubernetes-sigs/aws-load-balancer-controller/blame/main/docs/deploy/security_groups.md#L64
To make things consistent we either need to document that the annotation defaults to
false
or make the default actuallytrue
. Making ittrue
by default is probably the desired path for most setups.The text was updated successfully, but these errors were encountered: