Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optionally return full role arn including path during token verification #632

Closed
wants to merge 1 commit into from
Closed

Optionally return full role arn including path during token verification #632

wants to merge 1 commit into from

Conversation

terricain
Copy link

@terricain terricain commented Sep 27, 2023 •
edited

What this PR does / why we need it: When creating EKS nodegroups where the node's IAM role contains a path, the nodes fail to join the cluster. This adds the ability to look up a role's full ARN including the path and return that when verifying a token.

The reason this is needed is because the assume-role ARN that is returned by sts.get-caller-idendentity does not include the IAM role's path.

I've added a "role cache" which calles iam.list-roles and stores a mapping between the roles unique role ID and the full ARN, as the UserID returned by sts.get-caller-identity contains the roles unique ID therefore looking up the existing role's correct ARN is possible.

This does require the clusters IAM role to have the iam:ListRoles action. If the role cache gets an error when calling list roles and its not a transient error, it'll disable all future lookups and the functionality will revert to the original behaviour. I figured it would be better to make this more an opt in rather than a requirement as else it might just break nodes joining a cluster whenever its released.

Which issue(s) this PR fixes:
Fixes #268
Fixes #153

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Sep 27, 2023 •
edited

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: terrycain / name: Terry Cain (885868b)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Sep 27, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @terrycain!

It looks like this is your first PR to kubernetes-sigs/aws-iam-authenticator 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/aws-iam-authenticator has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 27, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @terrycain. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: terrycain
Once this PR has been reviewed and has the lgtm label, please assign jyotimahapatra for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Sep 27, 2023
@terricain
Copy link
Author

@dims / @nckturner / @nnmin-aws can we get a review on this please?

@nnmin-aws
Copy link
Contributor

/test

@k8s-ci-robot
Copy link
Contributor

@nnmin-aws: The /test command needs one or more targets.
The following commands are available to trigger required jobs:

  • /test pull-aws-iam-authenticator-e2e
  • /test pull-aws-iam-authenticator-e2e-kind
  • /test pull-aws-iam-authenticator-integration
  • /test pull-aws-iam-authenticator-unit

Use /test all to run all jobs.

In response to this:

/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nnmin-aws
Copy link
Contributor

/test all

@terricain
Copy link
Author

Thanks @nnmin-aws the tests seem to have passed, what now?

@terricain
Copy link
Author

@nnmin-aws @dims @nckturner what else is required for this PR? There's been no progress for nearly 2 months, some guidance would be appreciated.

@dims
Copy link
Member

dims commented Dec 23, 2023

cc @cartermckinnon

@nnmin-aws
Copy link
Contributor

@terrycain @dims apology for the delay! i am so sorry about it. We were hesitating at the change because it requires additional invocation of aws IAM and might increase latency of authN.

There is another PR actually merged https://github.com/kubernetes-sigs/aws-iam-authenticator/pull/670/files#diff-5de38ab8d77d935766314beeb9a9e3b7165eb470e656dbb5e4fdf9bb60ae59de. which removed the path from the arn comparison.

Could you please kindly pull latest release and verify if it works for your scenario? If it doesn't, we can check this PR again.

Thank you!

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 22, 2024
@terricain terricain closed this Mar 23, 2024
@terricain terricain deleted the fix_assume_role_path branch March 23, 2024 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinsb justinsb Awaiting requested review from justinsb

@jyotimahapatra jyotimahapatra Awaiting requested review from jyotimahapatra

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
5 participants
@terricain @k8s-ci-robot @nnmin-aws @dims @k8s-triage-robot