Unable to configure a specific hostname for notebook-controller generated VirtualServices

[josh-thisisbud]

Hey there, I'm running into an issue where Istio is preferring to route traffic to other cluster components due to them being more specific with their configured hostnames.

E.g. A request to dave.example.com/notebooks/dave/etc is preferring to go to a VS with host: dave.example.com, path: / than the generated virtualservice with host: ['*'], path: /notebooks/dave/etc

I would like to be able to expose my notebooks in a similar way, however I find that the hostname value is hardcoded into this service.

kubeflow/components/notebook-controller/controllers/notebook_controller.go

Line 499 in bd7f250

if err := unstructured.SetNestedStringSlice(vsvc.Object, []string{"*"}, "spec", "hosts"); err != nil {

[josh-thisisbud]

Suggested fix at #7529