Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate Skopt Suggestion Service #2280

Open
tenzen-y opened this issue Mar 10, 2024 · 23 comments
Open

Deprecate Skopt Suggestion Service #2280

tenzen-y opened this issue Mar 10, 2024 · 23 comments

Comments

@tenzen-y
Copy link
Member

/kind feature

Describe the solution you'd like
[A clear and concise description of what you want to happen.]
Unfortunately, the scikit-optimize was closed on February 29, 2024.

https://github.com/scikit-optimize/scikit-optimize

So we need to stop supporting the skopt suggestion service as well.
I think that we can follow similar deprecation steps as the MXNet.

Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]


Love this feature? Give it a 👍 We prioritize the features with the most 👍

@tenzen-y
Copy link
Member Author

@kubeflow/wg-automl-leads WDYT?

@PeterWrighten
Copy link

May I work for this issue?
/assign

@tenzen-y
Copy link
Member Author

/unassign @PeterWrighten

We need to follow the deprecation flow step by step.

@PeterWrighten
Copy link

/unassign @PeterWrighten

We need to follow the deprecation flow step by step.

Got it. Thanks!

@andreyvelich
Copy link
Member

That is sad to hear @tenzen-y.

Do we have any alternative to use Bayesian Optimization in Hyperopt or Optuna ?

@tenzen-y
Copy link
Member Author

That is sad to hear @tenzen-y.

Do we have any alternative to use Bayesian Optimization in Hyperopt or Optuna ?

Unfortunately, both optuna and Hyperopt don't provide Bayesian sampler.

@tenzen-y
Copy link
Member Author

If we want to provide Bayesian sample, we need to implement it ourselves.

@andreyvelich
Copy link
Member

Maybe we could check some Open Source BO implementations.
For example: https://github.com/bayesian-optimization/BayesianOptimization

Also, quite recently @contramundum53 added GPSampler support in Optuna: optuna/optuna#5185

Maybe we can re-use it.
cc @c-bata @a9p for your ideas here.

@tenzen-y
Copy link
Member Author

Also, quite recently @contramundum53 added GPSampler support in Optuna: optuna/optuna#5185

Oh, I didn't find that.

@tenzen-y
Copy link
Member Author

So, setting optuna as a default Bayesian sampler might be better.

@contramundum53
Copy link

@andreyvelich @tenzen-y I'm glad that you are considering integration of Optuna's GPSampler into katib!
GPSampler is planned to be released in Optuna v3.6, our next minor release. It is still experimental and future breaking changes/bugs are possible (the code is only a month old!), but if it's okay for you, we'll be happy to hear that.

@tenzen-y
Copy link
Member Author

@andreyvelich @tenzen-y I'm glad that you are considering integration of Optuna's GPSampler into katib! GPSampler is planned to be released in Optuna v3.6, our next minor release. It is still experimental and future breaking changes/bugs are possible (the code is only a month old!), but if it's okay for you, we'll be happy to hear that.

Oh, I see. Thank you for letting us know @contramundum53
Is there a graduation plan for GPSampler? For example, did the optuna community decide when GPSampler graduates to stable?

@contramundum53
Copy link

Sorry no, that will depend on many factors, such as how much the new feature is used, how many feature requests come, how many bugs we encounter, and so on.

@andreyvelich
Copy link
Member

Thanks for letting us know @contramundum53!

@tenzen-y @johnugeorge What do you think about it ? Should we use skopt for 1 Katib/Kubeflow release and add deprecation notice for users who will run experiments with bayesianoptimization algorithm ?
Also, implement GPSampler in Optuna Katib Suggestion and explain users how to update Katib Config to use BO from Optuna rather than from skopt ?
After some time we will remove skopt and fully rely on Optuna for bayesianoptimization algorithm ?

@tenzen-y
Copy link
Member Author

Sorry no, that will depend on many factors, such as how much the new feature is used, how many feature requests come, how many bugs we encounter, and so on.

@contramundum53 Thank you for letting me know!

@tenzen-y
Copy link
Member Author

@tenzen-y @johnugeorge What do you think about it ? Should we use skopt for 1 Katib/Kubeflow release and add deprecation notice for users who will run experiments with bayesianoptimization algorithm ?
Also, implement GPSampler in Optuna Katib Suggestion and explain users how to update Katib Config to use BO from Optuna rather than from skopt ?
After some time we will remove skopt and fully rely on Optuna for bayesianoptimization algorithm ?

@andreyvelich I totally agree with you.

@tenzen-y
Copy link
Member Author

/remove-release 0.16

@andreyvelich
Copy link
Member

@tenzen-y Should we try to add deprecation notice before the next release ?

@tenzen-y
Copy link
Member Author

@tenzen-y Should we try to add deprecation notice before the next release ?

@andreyvelich Shouldn't be marked as release 0.17, not 0.16?

@andreyvelich
Copy link
Member

Oh, sorry, my bad

@tenzen-y
Copy link
Member Author

Oh, sorry, my bad

no worries

Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@tenzen-y
Copy link
Member Author

/remove-lifecycle stale

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants