Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Console validate the GitHub token even when there is no changes #2172

Open
1 task done
fharper opened this issue May 1, 2024 · 0 comments
Open
1 task done

Console validate the GitHub token even when there is no changes #2172

fharper opened this issue May 1, 2024 · 0 comments
Labels
bug Something isn't working console Specific to the console application ux User Experience improvements

Comments

@fharper
Copy link
Member

fharper commented May 1, 2024

Which version of kubefirst are you using?

2.4.6

Which cloud provider?

None specific

Which DNS?

None specific

Which installation type?

UI (Console app)

Which distributed Git provider?

GitHub

Did you use a fork of gitops-template?

No

Which Operating System?

None specific

What is the issue?

The console seems to validate the GitHub token (probably the same for the GitLab one, but I didn't test) each type you put the focus out of its textbox. We probably want to validate it only when there are changes to the content of the textbox to limit the number of call.

CleanShot.2024-05-01.at.16.13.40.mp4

With that said, it would be transparent if doing so wouldn't remove the organization selection. It seems like it may be just the selection display but it's still selected somehow as I can still click on the next button.

Code of Conduct

  • I agree to follow this project's Code of Conduct
@fharper fharper added bug Something isn't working ux User Experience improvements console Specific to the console application labels May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working console Specific to the console application ux User Experience improvements
Projects
Status: No status
Development

No branches or pull requests

1 participant