Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kube-vip manifest rbac does not output a document alike https://kube-vip.io/manifests/rbac.yaml #769

Open
rgl opened this issue Feb 21, 2024 · 2 comments

Comments

@rgl
Copy link

rgl commented Feb 21, 2024

Describe the bug

With the v0.7.0 release, the rbac manifest ceased being available inside the git repository as it was in the previous versions (e.g. at https://github.com/kube-vip/kube-vip/blob/v0.6.4/docs/manifests/rbac.yaml) and started to be available at https://kube-vip.io/manifests/rbac.yaml.

Looking for a versioned alternative, I've found kube-vip manifest rbac, which seemed to return the expected rbac manifest, but instead, it returns:

$ kube-vip manifest rbac
typemetaapplyconfiguration:
  kind: ServiceAccount
  apiversion: v1
objectmetaapplyconfiguration:
  name: kube-vip
  generatename: null
  namespace: kube-system
  uid: null
  resourceversion: null
  generation: null
  creationtimestamp: null
  deletiontimestamp: null
  deletiongraceperiodseconds: null
  labels: {}
  annotations: {}
  ownerreferences: []
  finalizers: []
secrets: []
imagepullsecrets: []
automountserviceaccounttoken: null

Which I think is a bug, and it should have returned the same document that is currently at https://kube-vip.io/manifests/rbac.yaml.

To Reproduce
Steps to reproduce the behavior:

  1. Run kube-vip manifest rbac
  2. Compare the result with https://kube-vip.io/manifests/rbac.yaml

Expected behavior

I expected it to return the same document as the one available at https://kube-vip.io/manifests/rbac.yaml.

Environment (please complete the following information):

  • Kube-vip Version: 0.7.0
@thebsdbox
Copy link
Collaborator

Ah apologies, that was an experiment to auto generate the rbac as part of the CLI tooling. The client-go handling of rbac generation is quite difficult so I never completed it. 😐

@rgl
Copy link
Author

rgl commented Feb 22, 2024

If that is not going to be completed, maybe, include the rbac.yml as a static file, and return that from that go codepath?

My hope is to have a straightforward way to match the rbac.yml version with the kube-vip version. Preferably, it should came from the same binary or artifact, so we just need to download one thing. That way, we have no doubts whether the rbac manifest is compatible with the specific kub-vip version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants