Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IntOrString needs a wrapper #12

Open
kazk opened this issue Oct 31, 2021 · 1 comment
Open

IntOrString needs a wrapper #12

kazk opened this issue Oct 31, 2021 · 1 comment
Labels
codegen

Comments

@kazk
Copy link
Member

kazk commented Oct 31, 2021

k8s-pb/k8s-pb-codegen/protos/apimachinery/pkg/util/intstr/generated.proto

Lines 36 to 42 in 7b4bf26

message IntOrString {
optional int64 type = 1;
optional int32 intVal = 2;
optional string strVal = 3;
}

@kazk kazk added the codegen label Oct 31, 2021
@clux
Copy link
Member

clux commented Oct 31, 2021

Presumably to get an enum rather than a struct? We don't actually have any enums in the out directory at all.

The generated k8s-openapi one is marked as having alternative codegen and some special schema handling.

@clux clux mentioned this issue Nov 21, 2021
Open
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
codegen
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@clux @kazk