-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: add e2e test coverage report #1533
Labels
Comments
Just a rather drafty branch: https://github.com/kube-logging/logging-operator/tree/gha-add-go-test-coverage_e2e |
kudo's to pepov for finding this: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem? Please describe.
It would be great to have the e2e tests coverage reports as they cover much a bigger part of the code base compared to unit tests.
Some resources:
Describe the solution you'd like
Build the binary with
-cover
flag, run the binary withGOCOVERDIR=some_coverage_dir
and at the end of the e2e test run merge those files to have a nice (hopefully) high overall coverage report.Describe alternatives you've considered
I do not think there is any.
Additional context
The tricky part is getting those reports, because currently the CI runs the e2e tests using kind. As mentioned in the docs graceful shutdown is needed for the program to write it's report, so a simple
kubectl cp
command might not be enough (not tested, just a theory).The text was updated successfully, but these errors were encountered: