New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PromotedConstructorPropertyFixer suggestions #917
Labels
Comments
Hi @zanderwar, it seems like a good improvement, would you like to raise the PR? Do we need and option for
I don't understand, how is it breaking standards? It keeps the padding for what was before. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
If the existing class property has a doc block, then the positioning of it when it gets moved to the __constructor is a little whack
Adding the following to the bottom of
updateParameterSignature
resulted in perfect positioningA few additional options would be nice:
keep_class_property_docblocks
defaults totrue
padding
defaults to 4spacesCurrently you only put 1 whitespace in front of the promoted property which doesn't follow standards I believe.
The text was updated successfully, but these errors were encountered: