-
-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sign the windows EXE #393
Comments
That's awesome! Up for a PR? |
If you've got a certificate in the secrets store, sure. Otherwise, not sure how to get free certificates for code signing. LetsEncrypt won't cut the mustard. |
What does it require? |
Leaving this here from quick googling https://mkaz.blog/code/code-signing-a-windows-application/ |
From some research it appears obtaining a valid code signing certificate for Windows costs between $150-$500/year. There don't seem to be an exceptions for FOSS. Looks like this is something we can't do. I'll leave this open in case anyone wants to sponsor the project or donate a cert in the future. Maybe we should add a warning to the documentation @grampelberg ? |
Users that download the windows EXE will be prompted (by browser and OS) that it is not safe because the EXE isn't signed.
There is a GitHub Action for signing: https://github.com/marketplace/actions/code-sign-a-file-with-pfx-certificate
This would provide additional confidence for windows users of ksync.
The text was updated successfully, but these errors were encountered: