Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make KEYBD trap handling code multibyte-aware #460

Open
McDutchie opened this issue Feb 12, 2022 · 3 comments
Open

Make KEYBD trap handling code multibyte-aware #460

McDutchie opened this issue Feb 12, 2022 · 3 comments
Labels
TODO Things to be done before releasing

Comments

@McDutchie
Copy link

For background, see #307 and 6b77da2.

To do:

  1. Figure out how the edit.c code works
  2. Remove workaround applied in 6b77da2
  3. Rewrite what needs to be rewritten to make keytrap() and the code that calls it in ed_getchar() multibyte aware
@McDutchie McDutchie added the TODO Things to be done before releasing label Feb 12, 2022
@hckiang
Copy link

hckiang commented Dec 6, 2022

If you have figured out how edit.c works, it may also be good to extend the buffer size of .sh.edchar by the way. Currently if you set .sh.edchar to a longer string (say more than 100 chararacters) in the KEYBD trap the sequence will just be truncated. I have my own programmable autocompletion using the .sh.edchar mechanism but my completion is sometimes truncated because of this limitation.

@posguy99
Copy link

posguy99 commented Dec 7, 2022

I have my own programmable autocompletion...

Is that something you can share? Sounds very useful.

@hckiang
Copy link

hckiang commented Dec 8, 2022

very useful

I use it myself daily but it maybe not so useful for others yet because it's kind of hacky and half-baked. Nonetheless I've just uploaded it here. See the comments in autocmpt.sh to see how to use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TODO Things to be done before releasing
Projects
None yet
Development

No branches or pull requests

3 participants