Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Old poetry-dynamic-versioning-plugin #174

Open
BrianPugh opened this issue Sep 28, 2023 · 1 comment
Open

Old poetry-dynamic-versioning-plugin #174

BrianPugh opened this issue Sep 28, 2023 · 1 comment
Labels
bug Something isn't working help wanted Extra attention is needed kubectl-ng

Comments

@BrianPugh
Copy link

BrianPugh commented Sep 28, 2023

Which project are you reporting a bug for?

kubectl-ng

What happened?

It probably doesn't impact your workflow too much, but this repo is using a super old version of poetry-dyanmic-versioning in your release CI. You should probably update poetry to something more modern, and use poetry-dynamic-versioning[plugin].

However, I'm looking through your stuff, and it seems like you don't even use PDV? So should probably just remove it anyways.

Anything else?

No response

@BrianPugh BrianPugh added the bug Something isn't working label Sep 28, 2023
@jacobtomlinson
Copy link
Member

There are two Python packages in this repo kr8s and kubectl-ng. We are using PDV in kubectl-ng and I agree it should probably be brought up to date. But equally it's just a toy demo and kr8s is the important thing here so I'm not too worried.

If someone wants to fix things up I'd be happy to review a PR.

@jacobtomlinson jacobtomlinson added the help wanted Extra attention is needed label Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed kubectl-ng
Projects
None yet
Development

No branches or pull requests

2 participants