Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix subschema array items with oneOf showing up as Any type #1962

Merged
merged 5 commits into from
Jun 3, 2024

Conversation

jdweav
Copy link
Contributor

@jdweav jdweav commented May 15, 2024

Closes #1910

Tested against the cases described in #1910, both are now generating the expected Python classes, and replacing List[Any] with a list of the expected class.

Copy link

codecov bot commented Jun 1, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Please upload report for BASE (main@5bab627). Learn more about missing BASE report.

Files Patch % Lines
datamodel_code_generator/parser/jsonschema.py 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1962   +/-   ##
=======================================
  Coverage        ?   98.85%           
=======================================
  Files           ?       37           
  Lines           ?     4195           
  Branches        ?      976           
=======================================
  Hits            ?     4147           
  Misses          ?       30           
  Partials        ?       18           
Flag Coverage Δ
unittests 98.52% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Jun 1, 2024

CodSpeed Performance Report

Merging #1962 will not alter performance

Comparing jdweav:1910-oneof-subschema-array (cd39ef3) with main (5bab627)

Summary

✅ 29 untouched benchmarks

@koxudaxi koxudaxi merged commit b4ce235 into koxudaxi:main Jun 3, 2024
92 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

oneOf with subschema array items not incorporated/generated as Any for pydantic.v2
2 participants