-
-
Notifications
You must be signed in to change notification settings - Fork 912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Variable fonts have thin weights in v0.34.0 #7361
Comments
I additionally have this local fontconfig config:
|
The commit is correct as far as I can see, change your font family to fira code medium or fira code retina or whichever variant has the weight you like. Not sure why you are aliasing fira code to nerd font though. |
It doesn't seem like any of the Fira Code variations seem to change this behavior at all. These are the fonts in question here:
I also tried setting
I use that to support Nerd Font Symbols without using a patched font in applications that don't have a feature like Kitty's |
Use font_family Fira Code Light Then run kitty with --debug-font-fallback and post the output Repeat with font_family Fira Code |
|
OK, that's strange I will take a look when I have a minute. |
Well, looks like fontconfig is overloading index to also contain variable See #3711 |
Describe the bug
After updating to v0.34.0 the font weight of my terminal changed.
I bisected the git history between
v0.34.0
andv0.33.1
and found d2c21ee to be the culprit. If I revert that commit on top ofv0.34.0
it returns to the previous rendering.To Reproduce
Steps to reproduce the behavior:
font_family Fira Code
(https://github.com/tonsky/FiraCode/releases/tag/6.2)Screenshots
My config:
Left is v0.34.0, right is v0.34.0 with the revert
NONE config:
Left is v0.34.0, right is v0.34.0 with the revert
Environment details
Additional context
I was able to reproduce this with an empty kitty config
The text was updated successfully, but these errors were encountered: