@ducha-aiki can you help to triage importance in the feature module. Also to audit if we eventually have things to deprecate etc

@ johnnv1 Can I fix one of the files, for example, KeyNetConf, pull it, and if everything is okay, add more changes?

/assign Ikonsty

Go ahead, when the PR is ok for review you can ping me and @ducha-aiki for it 😄

hey @johnnv1 can you assign this to me

@rajshukla1102 Go ahead, but if possible, open separate PRs for each feature

@johnnv1 Thank you! looking forward to completing this soon😊

I've been reviewing the list of potential contributions and noticed that many tasks are either already completed or no longer relevant. However, I've identified a couple of areas where I believe I could contribute effectively:

• kornia.feature.matching._get_default_fginn_params
• kornia.feature.adalam.core.AdalamConfig

Could you please confirm if these contributions are still needed? I would appreciate any additional guidance or suggestions you might have on how to proceed.

Looking forward to your feedback!

Could you please confirm if these contributions are still needed?

Sure it's, place a PR for this, and if you have any questions you can ping me at kornia slack

For cases like AdalamConfig which is a typed dict within NoRequired, you will need to check if we will need to initialize it somehow or not. Based on this, you'll be able to define the types, and if necessary you'll need to add some isinstance checks in some places

aside from the typing, the asdict <-> config conversion as in the issue, should work fine

In #2880 the kornia.feature.sold2.sold2_detector.default_cfg config is refactored. I therefore also looked into kornia.feature.sold2.sold2.default_cfg:

• kornia.feature.sold2.sold2.default_cfg uses the same default_config as in SOLD2_detector plus the line_matcher_cfg. Shall we put the dataclass definitions in a separate file (e.g. sold2_dataclasses.py in utils)? This way we could avoid repetition.

Shall we put the dataclass definitions in a separate file (e.g. sold2_dataclasses.py in utils)? This way we could avoid repetition.

Yeap, the detector default config has the descriptor equals False different than other one. But you can unify it under a structures.py file in sold2 module ("kornia/feature/sold2/structures.py").