-
-
Notifications
You must be signed in to change notification settings - Fork 939
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update apply_colormap #2877
Comments
how are you planning to implement the LUT with f32 ? |
I've create two "premilinar" versions that allow to use batch > 1 and channels > 1 and range [0,1] in float:
And also I create a a benchmark comparing both version with implemented in kornia (only uint8, grayscale images and batch==1). Results:
In my opinion v2 could be the best option. |
Pretty nice cases, I liked it... about the supporting C > 1, the unique use case I think about is having one hot-coded tensor (categorical), do you see another use case? on top of that, I would like to keep support for uint tensors, so that we can use the function to generate colored images from categorical masks |
I add channel support because you was talking about it (#2794 (comment)), but I am not sure what the other use cases might be. Yes, we can keep support for uint tensors, simply by checking the input type and creating the keys with torch.linspace or torch.arange. |
馃殌 Feature -> Update apply_colormap
From #2794 (comment)
Discussion about ColorMaps -> apply_colormap function. (
kornia/kornia/color/colormap.py
Line 161 in 8df6c44
Motivation
Pitch
The text was updated successfully, but these errors were encountered: