Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the FaceDetection API based on the changes from libfacedetection.train API #1781

Open
edgarriba opened this issue Jul 6, 2022 · 5 comments · May be fixed by #2851
Open

Update the FaceDetection API based on the changes from libfacedetection.train API #1781

edgarriba opened this issue Jul 6, 2022 · 5 comments · May be fixed by #2851
Assignees
@cjpurackal
Labels
enhancement 🚀 Improvement over an existing functionality module: contrib
Milestone
kornia v0.7.3

Comments

@edgarriba
Copy link
Member

Update the FaceDetection API based on the changes from libfacedetection.train API
--> ShiqiYu/libfacedetection.train@e5c4a24

Originally posted by @edgarriba in #1780 (comment)
@edgarriba edgarriba added enhancement 🚀 Improvement over an existing functionality module: contrib labels Jul 6, 2022
@edgarriba
Copy link
Member Author

edgarriba commented Jul 6, 2022 •
edited

@ShiqiYu Did a quick check on kornia existing code and seems that still work.

However, worth to know how the new code/model differs. Any tip/help to update wit the new pytorch code update from libfacedetection would be very helpful.

@edgarriba
Copy link
Member Author

UPDATE: the api seems to be broken with the new weights

https://github.com/kornia/kornia/runs/7211645883?check_suite_focus=true

@edgarriba
Copy link
Member Author

UPDATE: added a backup of the previous weights under kornia/data

https://github.com/kornia/data/blob/main/yunet_final.pth

@kishore-s-15
Copy link

Hi @edgarriba, I'll look into this issue along with #1782.

@edgarriba
Copy link
Member Author

awesome !

@edgarriba edgarriba added this to the kornia v0.7.3 milestone Jan 10, 2024
@cjpurackal cjpurackal linked a pull request Mar 22, 2024 that will close this issue
Draft
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cjpurackal cjpurackal

Labels
enhancement 🚀 Improvement over an existing functionality module: contrib
Projects
None yet
Milestone
kornia v0.7.3
Development

Successfully merging a pull request may close this issue.

Update face detection (YuNet) cjpurackal/kornia
3 participants
@edgarriba @cjpurackal @kishore-s-15