Modify API of canny to support per batch thresholds #2692
kunaltyagi
started this conversation in
General
Replies: 2 comments
-
@kunaltyagi i think that would be a great addition. Also an opportunity the revisit the implementation. /cc @ducha-aiki |
Beta Was this translation helpful? Give feedback.
0 replies
-
The benchmark can be done with https://pytorch.org/tutorials/recipes/recipes/benchmark.html here https://github.com/kornia/kornia-benchmark we have some examples using it, we can also discuss further on the pr |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Right now, canny has a single threshold for all images in a batch. I want to add support for a threshold per image, but:
I'd like to know if the API change would be acceptable (from just float to float or torch.Tensor). If yes, I would also like some guidance for the benchmarking
Beta Was this translation helpful? Give feedback.
All reactions