enhance.image_histogram2d compatibility with torch.histogram

[kunaltyagi]

I'm wondering how I can get numerical outputs as close to torch.histrogram as possible (for single channel, single batch tensor).

[edgarriba]

not quite sure but i think this two functions have different purposes. Image histogram sums** over the last two dimensions of an image. The torch one, might not consider any spatial relationship in the image ?

** https://kornia.readthedocs.io/en/latest/_modules/kornia/enhance/histogram.html#image_histogram2d

[edgarriba]

i don't have an answer for that. You will have to check yourself torch implementation and see how it differ from ours

[kunaltyagi]

I found one issue in kornia's implementation: double counting due to torch.abs(u) <= 1 (items on the boundary are counted twice)

[edgarriba]

Can you submit a PR including/updating tests?

[kunaltyagi]

I'll try to get that done sometime next week

[edgarriba]

awesome !