Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sewer ignores fresh nonces in most responses, makes get-nonce requests too often #143

Open
mmaney opened this issue Feb 9, 2020 · 0 comments

Comments

@mmaney
Copy link
Collaborator

mmaney commented Feb 9, 2020

What is it that you would like to propose to add/remove/change?

Add a trivial cache to save the fresh nonces the server returns in most responses and use them when available instead of waiting for a new-nonce query.

Why do you want to add/remove/change that?

Politeness (stop squandering nonces that the server has to track), efficiency (the roundtrip to get a nonce for almost every request isn't huge, but this change saved 7 out of 9 new-nonce queries in my simple one-cert test).

How do you want to go about adding/removing/changing that?

Review PR to be attached here. NB: this builds on top of the wrap-requests PR, so if the latter isn't merged this one will... actually, I guess it would pull wrap-requests in, wouldn't it? If not, it would fail and have to be recreated, basically, with the caching done from multiple places.

@mmaney mmaney mentioned this issue Feb 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant