When launcher service is manually stopped, it should remain in the stopped state until manually started

[RebeccaMahany]

Sometimes, when stopping the launcher service via the Service Manager, we see a pop-up that says "Windows could not stop the LauncherKolideK2Svc service on Local Computer. Error 1067: The process terminated unexpectedly." Querying the service status (either via command line, or by closing and re-opening the Service Manager) shows that the service is then in the Running state.

Since the service terminated unexpectedly, the service manager starts up launcher again, which is why it does not remain in the Stopped state. We should investigate why the service is terminating unexpectedly, and stop it from doing so on service shutdown so that the service manager does not restart launcher.

This issue does not appear to occur when stopping the launcher service via command line (i.e. stop-service LauncherKolideK2Svc) -- in that case, launcher halts and the service remains in the stopped state until manually started again, which is the correct and desired behavior.

We've seen this issue both on 1.2.1 and 1.3.0.

[directionless]

Do you think this is a launcher issue, or a ServiceManager bug?

I've seen some potentially related, buggy behavior in ServiceManager. I never got to the bottom of it, but all kinds of weirdness would happen if I had the service manager open while simultaneous running command line tools or installing a package. It's like something in can only handle a single writer and is missing a lock

[RebeccaMahany]

I'm not sure where the issue lies exactly -- maybe only ServiceManager, or maybe ServiceManager+launcher.

[directionless]

The stated bug here is about how adjustments in the service manager don't stick. So I think this is entirely inside the service manager.

Something about how if it doesn't think it succeeded in the shutdown, it doesn't save the change to the desired state.