-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
layout() function broken for Views with padding -- path forward #6974
Comments
It's actually not stride(1) but stride(2) that fails: https://godbolt.org/z/14q5o136r |
Because the code should have used |
Also accessing stride(2) on a rank-2 view is kinda UB lol |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We have an issue because the LayoutLeft and LayoutRight class itself (not the mapping) has no place to store stride. As a consequence the following code is wrong:
Suggested path forward:
layout()
toKokkos::LayoutLeft/Right/Stride
and deprecatelayout()
wherestride!=extent
View::mapping()
-> return mdspan mappingsView(data_handle, mdspan_mapping_type map)
The text was updated successfully, but these errors were encountered: